Allow other manifests to define ::apache::mod{ 'ssl': }. #818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@smerrill I think I'd rather see this fixed by having the package for mod::ssl be configurable by parameter. Are you up for trying that fix? |
|
Waiting for CLA signature by @smerrill @smerrill - We require a Contributor License Agreement (CLA) for people who contribute to Puppet, but we have an easy click-through license with instructions, which is available at https://cla.puppetlabs.com/ Note: if your contribution is trivial and you think it may be exempt from the CLA, please post a short reply to this comment with details. http://docs.puppetlabs.com/community/trivial_patch_exemption.html |
|
@mhaskel, that sounds like a fine approach. I'll get a patch back soon. |
This will allow Apache from the httpd24 SCL on RHELish systems to include the proper mod_ssl package while still letting ssl ::apache::vhost defines work as expected. Add package_name param to ::apache::mod::ssl. Add a test for the package_name parameter. Update the package_name parameter test.
|
CLA signed by all contributors. |
igalic
added a commit
that referenced
this pull request
Aug 18, 2014
…tion
Allow other manifests to define ::apache::mod{ 'ssl': }.
traylenator
pushed a commit
to traylenator/puppetlabs-apache
that referenced
this pull request
Jun 7, 2022
v4.2.0 Release prep
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow Apache from the httpd24 SCL on RHELish systems to include the proper mod_ssl package while still letting SSL-enabled
::apache::vhostdefines work as expected.puppetlabs-apache works quite well with the RHEL/CentOS SCLs, like so:
That said, its mod_ssl package is named httpd24-mod_ssl. This can also be worked around on its own:
When an
apache::vhostis instantiated with the SSL parameter set to true, however, it will include::apache::mod::ssl, which happens to instantiate::apache::mod { 'ssl': }without any parameters. This PR allows the details of which package to use for::apache::mod { 'ssl': }to be defined and still allow SSL-enabled::apache::vhostdefines to work.